Re: [Xen-devel] [PATCH v6 22/31] xen/arm: ITS: Add virtual ITS availability check helper

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Vijay,

On 31/08/15 12:06, vijay.kilari@xxxxxxxxx wrote:
> diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
> index 659d919..1c88300 100644
> --- a/xen/include/asm-arm/vgic.h
> +++ b/xen/include/asm-arm/vgic.h
> @@ -110,7 +110,13 @@ static inline void sgi_target_init(struct sgi_target 
> *sgi_target)
>      sgi_target->list = 0;
>  }
>  
> +struct vgic_info {
> +    bool_t its_enabled;
> +};
> +
>  struct vgic_ops {
> +    /* Hold vGIC information */
> +    const struct vgic_info *info;

The vgic_ops are shared between all the domains so you will end up to
allow ITS on every domains.

Any domain specific value should go in the domain structure and not in
the vgic_ops.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel