Re: [Xen-devel] [PATCH 15/16] xen/vtd: prevent from assign the device with shared rmrr

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 06.09.15 at 06:19, <tiejun.chen@xxxxxxxxx> wrote:
> On 9/6/2015 11:19 AM, Tamas K Lengyel wrote:
>>> --- a/xen/drivers/passthrough/vtd/iommu.c
>>> +++ b/xen/drivers/passthrough/vtd/iommu.c
>>> @@ -2310,12 +2310,16 @@ static int intel_iommu_assign_device(
>>>               PCI_DEVFN2(bdf) == devfn &&
>>>               rmrr->scope.devices_cnt > 1 )
>>>          {
>>> +            u32 relaxed = flag & XEN_DOMCTL_DEV_RDM_RELAXED;
>>> +
>>>              printk(XENLOG_G_ERR VTDPREFIX
>>> -                   " cannot assign %04x:%02x:%02x.%u"
>>> +                   " Currently its %s to assign %04x:%02x:%02x.%u"
>>>                     " with shared RMRR at %"PRIx64" for Dom%d.\n",
>>> +                   relaxed ? "disallowed" : "risky",
>>>
>>
>> This debug message is backwards?
> 
> Yeah. Its indeed like this, relaxed ? "risky" : "disallowed"
> 
> But lets wait Jan's comment to step next.

What kind of comment are you expecting from me?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel