Re: [Xen-devel] [OSSTEST PATCH 02/13] Planner: docs: Minor fixes

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [OSSTEST PATCH 02/13] Planner: docs: Minor fixes"):
> On Wed, 2015-09-02 at 16:45 +0100, Ian Jackson wrote:
> >  sub alloc_resources {
> > -    my ($resourcecall) = pop @_;
> > +    my ($resourcecall) = pop @_; # $resourcecall->($plan);
> 
> Took me a while to work out this means $resourcecall is a function which
> should be called as shown, but now I've got that:
...
> Maybe consider adding "Called as" to the front of the comment though? (Ack
> either way)

Perl syntax like   $resourcecall->($plan)  always means that
$resourcecall is a subref which is being invoked.  And the variable is
called `call'.

So I think extra commentary would be redundant.

> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel