Re: [Xen-devel] [OSSTEST PATCH 04/13] Planner: Fix indefinite holdoff

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-09-02 at 16:45 +0100, Ian Jackson wrote:
> runneeded-ensure-will would always reset the runneeded_holdoff_after
> timer.  So no new queue run would start until no runneeded-ensure-will
> has occurred for (currently) 30s.
> 
> Instead, only start the timer if it's not already running.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> ---
>  ms-queuedaemon |   10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/ms-queuedaemon b/ms-queuedaemon
> index d6d59ee..1aa526c 100755
> --- a/ms-queuedaemon
> +++ b/ms-queuedaemon
> @@ -86,10 +86,12 @@ proc runneeded-ensure-will {need} {
>      log-event "runneeded-ensure-will $need (was $need_queue_run)"
>  
>      if {$need > $need_queue_run} { set need_queue_run $need }
> -    catch { after cancel $runneeded_holdoff_after }
> -    set runneeded_holdoff_after \
> -        [after [expr {$c(QueueDaemonHoldoff) * 1000}] \
> -             runneeded-perhaps-start]
> +
> +    if {![info exists runneeded_holdoff_after]} {
> +     set runneeded_holdoff_after \
> +         [after [expr {$c(QueueDaemonHoldoff) * 1000}] \
> +              runneeded-perhaps-start]
> +    }
>  }
>  
>  proc runneeded-perhaps-start {} {

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel