Re: [Xen-devel] [PATCH v5 01/22] xen/arm: Return success if dt node does not have irq mapping

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-07-27 at 16:41 +0530, vijay.kilari@xxxxxxxxx wrote:
> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
> 
> dt_for_each_irq_map() returns error if no irq mapping is found.
> With this patch, Ignore error and return success
> 
> Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Wei -- I think this fix would be good to have for 4.6. It is not an error
to process a zero-length (==non-existent) array I think.

Julien proposed retitling to "xen/dt: Handle correctly node with interrupt
-map in dt_for_each_irq_map", I think he meant s/with/without/ in that
though.

> ---
>  xen/common/device_tree.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
> index 323c3be..1325ad5 100644
> --- a/xen/common/device_tree.c
> +++ b/xen/common/device_tree.c
> @@ -1085,7 +1085,7 @@ int dt_for_each_irq_map(const struct dt_device_node 
> *dev,
>      if ( imap == NULL )
>      {
>          dt_dprintk(" -> no map, ignoring\n");
> -        goto fail;
> +        return 0;
>      }
>      imaplen /= sizeof(u32);
>  

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel