Re: [Xen-devel] [PATCH v2 5/8] tmem: Move TMEM_CONTROL subop of tmem hypercall to sysctl.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.08.15 at 21:20, <konrad.wilk@xxxxxxxxxx> wrote:
>> >>> --- a/xen/include/public/tmem.h
>> >>> +++ b/xen/include/public/tmem.h
>> >>> @@ -33,7 +33,7 @@
>> >>>  #define TMEM_SPEC_VERSION          1
>> >>>  
>> >>>  /* Commands to HYPERVISOR_tmem_op() */
>> >>> -#define TMEM_CONTROL               0
>> >>> +#define TMEM_CONTROL_MOVED         0
>> >> If anything, this should be deleted as opposed to being renamed.  The
>> >> _MOVED suffix is confusing, as TMEM_CONTROL_MOVED sounds like it could
>> >> be a plausible TMEM operation.
>> > Ah, will do what Jan asked and just put a big comment. And keep the old
>> > name (or maybe add 'DEPRECATED'?)
>> 
>> If you are going to the effort of renaming, then just delete.  Either
>> way will break the build of unsuspecting code, and the latter leaves us
>> with less junk.
> 
> It will break the tmem hypervisor code as it has a check for
> TMEM_CONTROL (which per Jan suggestion should return -E.. something).

That could be taken care of by putting the #define inside
#ifdef __XEN__ (and do the earlier suggested #undef in the
#else).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel