Re: [Xen-devel] [PATCH v2 5/8] tmem: Move TMEM_CONTROL subop of tmem hypercall to sysctl.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.08.15 at 20:43, <konrad.wilk@xxxxxxxxxx> wrote:
> On Thu, Aug 27, 2015 at 09:11:35AM -0600, Jan Beulich wrote:
>> >>> On 27.08.15 at 13:02, <konrad.wilk@xxxxxxxxxx> wrote:
>> > --- a/xen/include/public/sysctl.h
>> > +++ b/xen/include/public/sysctl.h
>> > @@ -710,6 +710,48 @@ struct xen_sysctl_psr_cat_op {
>> >  typedef struct xen_sysctl_psr_cat_op xen_sysctl_psr_cat_op_t;
>> >  DEFINE_XEN_GUEST_HANDLE(xen_sysctl_psr_cat_op_t);
>> >  
>> > +#define XEN_SYSCTL_TMEM_OP_ALL_CLIENTS 0xFFFFU
>> > +
>> > +#define XEN_SYSCTL_TMEM_OP_THAW                   0
>> > +#define XEN_SYSCTL_TMEM_OP_FREEZE                 1
>> > +#define XEN_SYSCTL_TMEM_OP_FLUSH                  2
>> > +#define XEN_SYSCTL_TMEM_OP_DESTROY                3
>> > +#define XEN_SYSCTL_TMEM_OP_LIST                   4
>> > +#define XEN_SYSCTL_TMEM_OP_SET_WEIGHT             5
>> > +#define XEN_SYSCTL_TMEM_OP_SET_CAP                6
>> > +#define XEN_SYSCTL_TMEM_OP_SET_COMPRESS           7
>> > +#define XEN_SYSCTL_TMEM_OP_QUERY_FREEABLE_MB      8
>> > +#define XEN_SYSCTL_TMEM_OP_SAVE_BEGIN             10
>> > +#define XEN_SYSCTL_TMEM_OP_SAVE_GET_VERSION       11
>> > +#define XEN_SYSCTL_TMEM_OP_SAVE_GET_MAXPOOLS      12
>> > +#define XEN_SYSCTL_TMEM_OP_SAVE_GET_CLIENT_WEIGHT 13
>> > +#define XEN_SYSCTL_TMEM_OP_SAVE_GET_CLIENT_CAP    14
>> > +#define XEN_SYSCTL_TMEM_OP_SAVE_GET_CLIENT_FLAGS  15
>> > +#define XEN_SYSCTL_TMEM_OP_SAVE_GET_POOL_FLAGS    16
>> > +#define XEN_SYSCTL_TMEM_OP_SAVE_GET_POOL_NPAGES   17
>> > +#define XEN_SYSCTL_TMEM_OP_SAVE_GET_POOL_UUID     18
>> > +#define XEN_SYSCTL_TMEM_OP_SAVE_GET_NEXT_PAGE     19
>> > +#define XEN_SYSCTL_TMEM_OP_SAVE_GET_NEXT_INV      20
>> > +#define XEN_SYSCTL_TMEM_OP_SAVE_END               21
>> > +#define XEN_SYSCTL_TMEM_OP_RESTORE_BEGIN          30
>> > +#define XEN_SYSCTL_TMEM_OP_RESTORE_PUT_PAGE       32
>> > +#define XEN_SYSCTL_TMEM_OP_RESTORE_FLUSH_PAGE     33
>> 
>> Perhaps better to have all these in tmem.h, to not clutter this
>> header?
> 
> Yes and no. The other sysctl had their #defines for commands here so I 
> figured I
> would follow that rule. But I am OK keeping it in tmem.h and just do
> 
> /* For the 'cmd' values consule tmem.h. Look for XEN_SYSCTL_TMEM_OP_* */

Having seen Andrew's reply, I'd like to clarify that I'm not insisting
on where these go - I just voiced my opinion without meaning for
it to stand in the way of this going in.

>> > --- a/xen/include/public/tmem.h
>> > +++ b/xen/include/public/tmem.h
>> > @@ -33,7 +33,7 @@
>> >  #define TMEM_SPEC_VERSION          1
>> >  
>> >  /* Commands to HYPERVISOR_tmem_op() */
>> > -#define TMEM_CONTROL               0
>> > +#define TMEM_CONTROL_MOVED         0
>> 
>> Perhaps say where it moved in a brief comment?
> 
> Yes, good idea.
> 
> /* Deprecated. These operations are done now via XEN_SYSCTL_tmem_op
>  * using the sysctl hypercall. */

It's not deprecated (or else it would still work), it's no longer
supported. After having written to original reply, I thought
of

#undef TMEM_CONTROL /* replaced by XEN_SYSCTL_tmem_op */

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel