Re: [Xen-devel] [PATCH v4 2/4] x86/compat: Test both PV and PVH guests for compat mode

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.08.15 at 20:12, <boris.ostrovsky@xxxxxxxxxx> wrote:
> @@ -777,7 +777,7 @@ int arch_set_info_guest(
>  
>      /* The context is a compat-mode one if the target domain is compat-mode;
>       * we expect the tools to DTRT even in compat-mode callers. */
> -    compat = is_pv_32bit_domain(d);
> +    compat = is_pv_32bit_domain(d) || is_pvh_32bit_domain(d);

I continue to think that this should include a v->domain ==
current->domain check (to match behavior for HVM guests
from the tool stack perspective). Having looked at patch 4, I also
can't see how the tool stack is being made expect a non-native
guest context record in the 32-bit PVH case (i.e. I'd appreciate
if you could point out where that hides).

> @@ -1203,7 +1204,7 @@ void arch_get_info_guest(struct vcpu *v, 
> vcpu_guest_context_u c)
>  {
>      unsigned int i;
>      const struct domain *d = v->domain;
> -    bool_t compat = is_pv_32bit_domain(d);
> +    bool_t compat = is_pv_32bit_domain(d) || is_pvh_32bit_domain(d);

Same here then naturally.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel