[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86/vmx: fix vmx_is_singlestep_supported return value



On Mon, Aug 24, 2015 at 03:55:33PM -0400, Tamas K Lengyel wrote:
> The function supposed to return a boolean but instead it returned
> the value 0x8000000 which is the Intel internal flag for MTF. This has
> caused various checks using this function to falsely report no MTF
> capability.
> 
> Signed-off-by: Tamas K Lengyel <tlengyel@xxxxxxxxxxx>

Release-acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

> ---
>  xen/arch/x86/hvm/vmx/vmx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
> index 999defe..35bcd79 100644
> --- a/xen/arch/x86/hvm/vmx/vmx.c
> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> @@ -1768,7 +1768,7 @@ static void vmx_enable_msr_exit_interception(struct 
> domain *d)
>  
>  static bool_t vmx_is_singlestep_supported(void)
>  {
> -    return cpu_has_monitor_trap_flag;
> +    return cpu_has_monitor_trap_flag ? 1 : 0;
>  }
>  
>  static void vmx_vcpu_update_eptp(struct vcpu *v)
> -- 
> 2.1.4

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.