Re: [Xen-devel] [PATCH for-4.6 v2 1/3] xl: fix vNUMA vdistance parsing

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2015-08-13 at 16:41 +0100, Wei Liu wrote:
> We should parse the output from splitting function, not the original
> string.

What is the previous incorrect behaviour in practice? It is useful to
say this so that when someone comes along and says I'm seeing strange
behaviour $FOO there is some chance of either remembering this or
spotting it in the commit message.

It would also inform my opinion as to whether/why this change is
correct.

> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> Reviewed-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> ---
>  tools/libxl/xl_cmdimpl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index 499a05c..078acd1 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -1188,7 +1188,7 @@ static void parse_vnuma_config(const XLU_Config 
> *config,
>                      len = libxl_string_list_length(&vdist);
>  
>                      for (j = 0; j < len; j++) {
> -                        val = parse_ulong(value);
> +                        val = parse_ulong(vdist[j]);
>                          p->distances[j] = val;
>                      }
>                      libxl_string_list_dispose(&vdist);

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel