Re: [Xen-devel] [PATCH v3 07/32] xen/x86: fix arch_set_info_guest for HVM guests

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.08.15 at 20:08, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 03/08/15 18:31, Roger Pau Monnà wrote:
>> struct vcpu_hvm_x86_16 {
>>     uint16_t ax;
>>     uint16_t cx;
>>     uint16_t dx;
>>     uint16_t bx;
>>     uint16_t sp;
>>     uint16_t bp;
>>     uint16_t si;
>>     uint16_t di;
>>     uint16_t ip;
>>
>>     uint32_t cr[8];
> 
> Definitely no need for anything other than cr0 and 4 in 16 bit mode.
> 
>>
>>     uint32_t cs_base;
>>     uint32_t ds_base;
>>     uint32_t ss_base;
>>     uint32_t cs_limit;
>>     uint32_t ds_limit;
>>     uint32_t ss_limit;
>>     uint16_t cs_ar;
>>     uint16_t ds_ar;
>>     uint16_t ss_ar;
>> };
>>
>> struct vcpu_hvm_x86_32 {
>>     uint32_t eax;
>>     uint32_t ecx;
>>     uint32_t edx;
>>     uint32_t ebx;
>>     uint32_t esp;
>>     uint32_t ebp;
>>     uint32_t esi;
>>     uint32_t edi;
>>     uint32_t eip;
>>
>>     uint32_t cr[8];
> 
> Don't need cr's 5-8.

I disagree with a number of things discussed so far (like the statement
above), but I guess I'll better comment on v4 than continue this thread.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel