Re: [Xen-devel] [PATCH v8 1/2] OSSTEST: introduce a raisin build test

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 4 Aug 2015, Ian Campbell wrote:
> On Tue, 2015-08-04 at 12:18 +0100, Stefano Stabellini wrote:
> > On Tue, 4 Aug 2015, Ian Campbell wrote:
> > > On Thu, 2015-07-23 at 17:52 +0100, Stefano Stabellini wrote:
> > > > +sub build () {
> > > > +    target_cmd_build($ho, 9000, $builddir, <<END);
> > > > +        cd $raisindir
> > > > +        ./raise -n build
> > > > +END
> > > > +#/;
> > > 
> > > Running this is pretty quiet it seems, which is normally good but I 
> > > think
> > > for automated test we likely want to crank up the verbosity somewhat. 
> > > Is
> > > that possible?
> > 
> > -v for verbose
> > 
> > ./raise -v -n build
> > 
> > 
> > > Or else if this is being captured into some logfile somewhere we should
> > > capture that.
> > > 
> > > It also said:
> > >     [raisin] Missing packages: pciutils-dev
> > > which I guess is something which needs to be added to ts-xen-build
> > > -prep?
> > 
> > This is a mismatch between raisin's build dependency list and osstest's.
> > I thought that OSSTest might not want to add pciutils-dev as a
> > dependency, this is why I didn't add it.
> 
> On the contrary I think we probably do want it, especially if without it
> passthrough doesn't work, we should be at least build testing that!

fair enough, I can add them


> > > It hasn't actually failed though, is that normal?
> >  
> > It is an "optional" dependency, without it passthrough is disabled in
> > qemu-traditional. Passing -n tell raisin to "shut up, do nothing and
> > continue", so at the end the build still succeed.
> 
> What other sorts of things are optional?

There isn't really a distinction between mandatory dependencies and
optional dependencies in raisin. This is what raisin is currently
complaining about:

bridge-utils pciutils-dev libnl-3-dev libnl-route-3-dev

bridge-utils is actually a run time dependency for Xen, while
libnl-3-dev and libnl-route-3-dev are build time dependencies for
libvirt. I think they are needed for vlan support. Should I add them
too?


> I think there could be an argument
> for osstest insisting on as much stuff as possible being enabled and
> therefore for asking raisin to be pedantic about optional deps.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel