Re: [Xen-devel] [PATCH v2] build: use correct qemu path in systemd service file and init script

[Doug Goldstein <cardoe@xxxxxxxxxx>]

On Thu, Jul 30, 2015 at 6:35 AM, Ian Campbell <ian.campbell@xxxxxxxxxx> wrote:
> On Thu, 2015-07-30 at 12:23 +0100, Anthony PERARD wrote:
>> On Thu, Jul 30, 2015 at 11:24:47AM +0100, Ian Campbell wrote:
>> > On Thu, 2015-07-30 at 14:51 +0800, Ting-Wei Lan wrote:
>> > > When --with-system-qemu is used, it is possible that we cannot find
>> > > qemu-system-i386 in LIBEXEC_BIN, which can cause error in xencommons
>> > > init script and xen-qemu-dom0-disk-backend.service systemd service.
>> > >
>> > > Signed-off-by: Ting-Wei Lan <lantw44@xxxxxxxxx>
>> >
>> > Personally I would have omitted the distinction between @qemu_xen_path@
>> > and
>> > @qemu_xen_systemd@ and just put the env invocation in the service file
>> > as
>> > "/usr/bin/env @qemu_xen_path@" but I suppose that is just bike
>> > shedding,
>> > so:
>> >
>> > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>> >
>> > Wei Lui, what do you think about this for 4.6? It fixes a real issue
>> > where
>> > --with-system-qemu is used without an explicit path, which is supposed
>> > to
>> > search for "qemu" in $PATH but fails to do so for the initscripts and
>> > unit
>> > files, where it uses the old hardcoded default value instead, which
>> > probably doesn't exist if you are using this option (and if it did
>> > isn't
>> > the thing the user asked for).
>> >
>> > The fix looks pretty straight forward to me.
>> >
>> > Mostly unrelated, is "qemu" a sensible default here? No binary package
>> > on
>> > Debian actually provides a "qemu" binary, they are all qemu-system-foo
>> > or
>> > variants. I'm not sure if that's just a Debian packaging issue though.
>> > I've
>> > added the Qemu-xen maintainers for input...
>>
>> QEMU does not build a binary called 'qemu', so this would be package
>> specific. So I think a default should be either 'qemu-system-i386' or
>> fail if no path is provided.
>
> Thanks. I think we should take Ting-Wei's patch as is for 4.6 and fixup the
> default to be qemu-system-i386 in 4.7.
>
> Ian.
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

Ian,

I would actually advise against using the name "qemu" because upstream
explicitly asked distros not to use that since 1.0.

http://wiki.qemu.org/ChangeLog/1.0

You should always use "qemu-system-i386".

-- 
Doug Goldstein

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel