Re: [Xen-devel] [PATCH RFC] Traps: Enable pass-through SMC call support for guest OS's.

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-07-29 at 16:53 -0400, Brandon Perez wrote:
> Originally, Xen did not allow for guests to make SMC calls. However, on the 
> DRA7
> chips, the kernel needs to make several SMC calls to interact with the secure
> ROM code.
> 
> There are two solutions for solving this in the patch. The selected method is 
> to
> simply allow the kernel to make the call, without going through the 
> hypervisor.
> The other is to trap and emulate the call in the hypervisor.

I think we shouldn't be letting even dom0 make unfettered calls to the
secure world.

I think that means we need to continue to trap but also to call a platform
specific hook which filters which calls are allowed through (looking at the
immediate as well as the register contents). This will also give us an
opportunity to translate anything which needs to be translated (e.g. from
IPA to PA perhaps).

A platform with no hook provided should default to deny.

The actually call to smc should be via smc.S, you will need to refactor
call_smc into call_smc0 and call_smc1, and you may want to add a
convenience wrapper in the platform code.

> 
> Signed-off-by: Brandon Perez <bperez-1@xxxxxx>
> ---
>  xen/arch/arm/traps.c |   15 ++++++++++++++-
>  1 file changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
> index 258d4c5..9b9de7b 100644
> --- a/xen/arch/arm/traps.c
> +++ b/xen/arch/arm/traps.c
> @@ -123,8 +123,9 @@ void __cpuinit init_traps(void)
>                   CPTR_EL2);
> 
>      /* Setup hypervisor traps */
> +    // TODO: Choose method
>      WRITE_SYSREG(HCR_PTW|HCR_BSU_INNER|HCR_AMO|HCR_IMO|HCR_FMO|HCR_VM|
> -                 HCR_TWE|HCR_TWI|HCR_TSC|HCR_TAC|HCR_SWIO|HCR_TIDCP, 
> HCR_EL2);
> +                 HCR_TWE|HCR_TWI/*|HCR_TSC*/|HCR_TAC|HCR_SWIO|HCR_TIDCP, 
> HCR_EL2);
>      isb();
>  }
> 
> @@ -2494,6 +2495,18 @@ asmlinkage void do_trap_hypervisor(struct 
> cpu_user_regs *regs)
>          GUEST_BUG_ON(!psr_mode_is_32bit(regs->cpsr));
>          perfc_incr(trap_smc32);
>          inject_undef32_exception(regs);
> +// TODO: Choose method
> +/*#define omap5_smc(func_id, arg1) \
> +        asm volatile ("push {r1-r12, lr}\n\t" \
> +                      "mov r12,%0\n\t" \
> +                      "mov r0,%1\n\t" \
> +                      "smc #1\n\t" \
> +                      "pop {r1-r12, lr}" \
> +                      : \
> +                      : "r" (func_id), "r" (arg1))
> +
> +        omap5_smc(regs->r12, regs->r0);
> +        advance_pc(regs, hsr); */
>          break;
>      case HSR_EC_HVC32:
>          GUEST_BUG_ON(!psr_mode_is_32bit(regs->cpsr));
> --
> 1.7.9.5
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel