Re: [Xen-devel] [PATCH v5 05/22] xen/arm: ITS: Port ITS driver to Xen

[Vijay Kilari <vijay.kilari@xxxxxxxxx>]

On Wed, Jul 29, 2015 at 9:36 PM, Ian Campbell <ian.campbell@xxxxxxxxxx> wrote:
> On Wed, 2015-07-29 at 20:52 +0530, Vijay Kilari wrote:
>> Hi Julien,
>>
>>   Can you please explain what is the problem with making a function
>> non-static for compilation purpose and later make it static when used?
>
> It's noise in the series, which makes it harder to review and it is noise
> in the history which makes it hard to follow what happened.
>
> You should structure the series so that each patch individually makes sense
> and builds upon the previous patches. Introducing things only to remove
> them later, or making the non-static just to keep the compiler happy until
> they are used is a sign that your series is badly organised, which you
> should fix.

I understand, it is tough to manage 4000+ lines of code.
I will try my best in my next series. but I _cannot_ assure 100% ;-)

>
>> In anycase we are going to merge all the patches at once.
>
> I'm afraid that doesn't matter, each point in the series should standalone.
>
> http://wiki.xen.org/wiki/Submitting_Xen_Patches#Making_good_patches covers
> some of this.
>
> Ian.
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel