Re: [Xen-devel] [PATCH v3 32/32] libxl: allow the creation of HVM domains without a device model.

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 29/07/15 15:43, Roger Pau Monné wrote:
>> There is a path that dm_present contains garbage.
> Please take into account that I've removed the last break in
> LIBXL_DOMAIN_TYPE_HVM, so now the LIBXL_DOMAIN_TYPE_HVM case expands
> into the LIBXL_DOMAIN_TYPE_PV case.

As a general note, please mark deliberate fallthough cases with a
comment, even if it is just /* fallthrough */

This is an aid to Coverity spotting accidental fallthrough.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel