Re: [Xen-devel] [RFC PATCH v3.1 2/2] xsplice: Add hook for build_id

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 27/07/15 20:20, Konrad Rzeszutek Wilk wrote:
> diff --git a/xen/include/xen/compile.h.in b/xen/include/xen/compile.h.in
> index 440ecb2..939685e 100644
> --- a/xen/include/xen/compile.h.in
> +++ b/xen/include/xen/compile.h.in
> @@ -10,4 +10,5 @@
>  #define XEN_EXTRAVERSION     "@@extraversion@@"
>  
>  #define XEN_CHANGESET                "@@changeset@@"
> +#define XEN_BUILD_ID        "@@changeset@@"

I am not sure putting the changeset into the build id field is sensible.

On the other hand, linking .note.gnu.build-id and exposing it as
XENVER_build_id seems like a very sensible thing to do.  It would
probably make sense to expose it in `xl info`.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel