Re: [Xen-devel] [PATCH v2] libxc: fix memory leak in migration v2

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Sun, 2015-07-26 at 22:36 +0100, Andrew Cooper wrote:
> On 26/07/2015 22:34, Wei Liu wrote:
> > Originally there was only one counter to keep track of pages. It 
> was
> > used erroneously to keep track of how many pages were mapped and 
> how
> > many pages needed to be sent. In the end munmap(2) always had 0 as 
> the
> > length argument, which resulted in leaking the mapping.
> >
> > This problem was discovered on 32bit toolstack because 32bit 
> applications
> > have notably smaller address space. In fact this bug affects 64bit
> > toolstack too.
> >
> > Use a separate counter to keep track of the number of mapped pages 
> to
> > solve this problem.
> >
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > ---
> > Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

acked and applied, thanks all.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel