Re: [Xen-devel] [PATCH OSSTEST 2/3] ts-debian-hvm-install: di_installcmdline_core

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH OSSTEST 2/3] ts-debian-hvm-install: 
di_installcmdline_core"):
> This is primarily to get DEBIAN_FRONTEND=test, for easier to read
> logging.
...
>  sub grub_cfg () {
> +    my @dicmdline = ();
> +    my $gconsole = "console=ttyS0,115200n8";
> +
> +    push @dicmdline, $gconsole;
> +    push @dicmdline, di_installcmdline_core($gho, '/preseed.cfg',
> +                                         PreseedScheme => 'file');
> +    push @dicmdline, "--";
...
>  sub isolinux_cfg () {
> +    my @dicmdline = ();
> +    my $gconsole = "console=ttyS0,115200n8";
> +
> +    push @dicmdline, $gconsole;
> +    push @dicmdline, di_installcmdline_core($gho, '/preseed.cfg',
> +                                         PreseedScheme => 'file');
> +    push @dicmdline, "initrd=/install.amd/initrd.gz";
> +    push @dicmdline, "--";
>      # See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=762007 for
>      # why console= is repeated.
> +    push @dicmdline, $gconsole;
> +
> +    my $cmdline = join(" ", @dicmdline);

These are uncomfortably similar, don't you think ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel