Re: [Xen-devel] [PATCH v3 07/32] xen/x86: fix arch_set_info_guest for HVM guests

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 24.07.15 at 13:28, <ian.campbell@xxxxxxxxxx> wrote:
> On Fri, 2015-07-24 at 12:11 +0100, Andrew Cooper wrote:
>> 
>> To avoid making the 32bit (and optionally 16bit) massive as a side 
>> effect of 64bit, can I suggest
>> 
>> uint32_t flags;
>> union {
>>      cpu_hvm32_regs;
>>      cpu_hvm64_regs;
>> };
>> 
>> Which allows hvm32_regs to be a far smaller structure.
> 
> Given that you can't really know apriori which mode an HVM vcpu is in
> and that having to pick the right half of the union everywhere is faff
> for everyone on both sides of the API I'd suggest going with a single
> struct as far as possible Perhaps with a union to allow the use of 32-
> and 64-bit _names_ for things which are the same underlying register in
> different widths (rip/pc, eax/rax etc), but that would be it.

While I had considered that too (not the least based on what you've
said ARM has), it has its own downsides (the hypervisor needing to
verify that everything that can't be represented is zero), which is
why I wasn't certain whether to suggest that.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel