Re: [Xen-devel] [PATCH for 4.6] xen/tools: Widen the machine_irq in xc_domain_*bind_pt_irq_int

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-07-21 at 15:15 +0100, Ian Campbell wrote:
> On Fri, 2015-07-17 at 15:06 +0100, Julien Grall wrote:
> > The DOMCTLs {,un}bind_pt_irq are using uint32_t for the machine_irq
> > while the helper is using uint8_t.
> > 
> > Currently on ARM, we are supporting SPIs whose irq number can go up 
> > 
> > to
> > 1019 which doesn't fit in an uint8_t. The helpers 
> > xc_domain_bind_pt_spi
> > and xc_domain_unbint_pt_spi are correctly taking an uint16_t so the
> > libxc was truncating without noticing the user which may end up to
> > route the wrong IRQ.
> > 
> > Fix the problem by widening the machine_irq parameter in
> > xc_domain_*bind_pt_irq_int.
> > 
> > Note that XEN_DOMCTL_irq_permission has the same problem but it's 
> > not
> > used at the moment on ARM. So we can defer the changes after the 
> > release
> > of Xen 4.7.
> > 
> > Reported-by: Iurii Konovalenko <iurii.konovalenko@xxxxxxxxxxxxxxx>
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> I think this is a bugfix and should be applied for 4.6.

Done.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel