Re: [Xen-devel] [PATCH v2 11/20] tty/hvc: xen: Use xen page definition

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 09/07/15 21:42, Julien Grall wrote:
> The console ring is always based on the page granularity of Xen.
[...]
> --- a/drivers/tty/hvc/hvc_xen.c
> +++ b/drivers/tty/hvc/hvc_xen.c
> @@ -392,7 +392,7 @@ static int xencons_connect_backend(struct xenbus_device 
> *dev,
>       if (xen_pv_domain())
>               mfn = virt_to_mfn(info->intf);
>       else
> -             mfn = __pa(info->intf) >> PAGE_SHIFT;
> +             mfn = __pa(info->intf) >> XEN_PAGE_SHIFT;

Change this to

gfn = xen_page_to_gfn(virt_to_page(info->intf));

and drop the if()?

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel