Re: [Xen-devel] [v4 15/17] arm: add a dummy arch hooks for scheduler

["Wu, Feng" <feng.wu@xxxxxxxxx>]

> -----Original Message-----
> From: Julien Grall [mailto:julien.grall@xxxxxxxxxx]
> Sent: Thursday, July 23, 2015 7:54 PM
> To: Wu, Feng; xen-devel@xxxxxxxxxxxxx
> Cc: Stefano Stabellini; Ian Campbell; Tim Deegan
> Subject: Re: [Xen-devel] [v4 15/17] arm: add a dummy arch hooks for scheduler
> 
> Hi,
> 
> On 23/07/15 12:35, Feng Wu wrote:
> > Add a dummy arch hooks for scheduler to make the build successful
> > in ARM.
> 
> I would make more sense if you introduce the dummy hooks in the patch
> where you effectively use it (i.e #16).
> 
> Actually you also introduce arch_vcpu_wake for x86 there too.

I split it just because this is the only changes to ARM. I will make them
one patch any way.

Thanks,
Feng

> 
> > CC: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > CC: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
> > CC: Tim Deegan <tim@xxxxxxx>
> > Signed-off-by: Feng Wu <feng.wu@xxxxxxxxx>
> > ---
> > v4:
> > - Newly added
> >
> >  xen/include/asm-arm/domain.h | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
> > index f1a087e..7f25fd5 100644
> > --- a/xen/include/asm-arm/domain.h
> > +++ b/xen/include/asm-arm/domain.h
> > @@ -265,6 +265,8 @@ static inline unsigned int domain_max_vcpus(const
> struct domain *d)
> >      return MAX_VIRT_CPUS;
> >  }
> >
> > +static void arch_vcpu_wake(struct vcpu *v) {}
> > +
> 
> Please use static inline here.
> 
> >  #endif /* __ASM_DOMAIN_H__ */
> >
> >  /*
> >
> 
> Regards,
> 
> --
> Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel