Re: [Xen-devel] [PATCH v7 13/15] x86/altp2m: XSM hooks for altp2m HVM ops

["Sahita, Ravi" <ravi.sahita@xxxxxxxxx>]

>From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
>Sent: Thursday, July 23, 2015 9:09 AM
>
>>>> On 23.07.15 at 01:01, <edmund.h.white@xxxxxxxxx> wrote:
>> --- a/xen/arch/x86/hvm/hvm.c
>> +++ b/xen/arch/x86/hvm/hvm.c
>> @@ -6005,6 +6005,9 @@ static int hvmop_set_param(
>>                  nestedhvm_vcpu_destroy(v);
>>          break;
>>      case HVM_PARAM_ALTP2M:
>> +        rc = xsm_hvm_param_altp2mhvm(XSM_PRIV, d);
>> +        if ( rc )
>> +            break;
>>          if ( a.value > 1 )
>>              rc = -EINVAL;
>>          if ( a.value &&
>> @@ -6189,6 +6192,9 @@ static int do_altp2m_op(
>>          goto out;
>>      }
>>
>> +    if ( (rc = xsm_hvm_altp2mhvm_op(XSM_TARGET, d ? d : current-
>>domain)) )
>> +        goto out;
>> +
>
>Shouldn't this have got updated after the changes to patch 11?

It was updated - a number of similar calls to check xsm permissions for this op 
were collapsed due to the sub-op'ing.
We don't differentiate across sub-ops for altp2m w.r.t. XSM permissions.

Thanks,
Ravi

>
>Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel