Re: [Xen-devel] [PATCH 03/16] xen/passthrough: extend hypercall to support rdm reservation policy

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.07.15 at 13:45, <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> Ian Jackson writes ("[PATCH 03/16] xen/passthrough: extend hypercall to 
> support rdm reservation policy"):
>> From: Tiejun Chen <tiejun.chen@xxxxxxxxx>
>> 
>> This patch extends the existing hypercall to support rdm reservation policy.
>> We return error or just throw out a warning message depending on whether
>> the policy is "strict" or "relaxed" when reserving RDM regions in pfn space.
>> Note in some special cases, e.g. add a device to hwdomain, and remove a
>> device from user domain, 'relaxed' is fine enough since this is always safe
>> to hwdomain.
> 
> This patch breaks the build on ARM:
> 
> gcc -O1 -fno-omit-frame-pointer -marm -g -fno-strict-aliasing -std=gnu99 
> -Wall 
> -Wstrict-prototypes -Wdeclaration-after-statement 
> -Wno-unused-but-set-variable 
> -Wno-unused-local-typedefs   -I/local/scratch/ianj/xen.git/xen/include 
> -fno-stack-protector -fno-exceptions -Wnested-externs -msoft-float 
> -mcpu=cortex-a15 
> -DGCC_HAS_VISIBILITY_ATTRIBUTE -fno-builtin -fno-common -Werror 
> -Wredundant-decls 
> -Wno-pointer-arith -pipe -g -D__XEN__ -include 
> /local/scratch/ianj/xen.git/xen/include/xen/config.h -nostdinc 
> -fno-optimize-sibling-calls -DVERBOSE -DHAS_PASSTHROUGH -DHAS_DEVICE_TREE 
> -DHAS_MEM_ACCESS -DHAS_PDX -fno-omit-frame-pointer -DCONFIG_FRAME_POINTER 
> -MMD -MF 
> .smmu.o.d -c smmu.c -o smmu.o
> smmu.c: In function 'arm_smmu_reassign_dev':
> smmu.c:2712:9: error: too few arguments to function 'arm_smmu_assign_dev'
>    ret = arm_smmu_assign_dev(t, devfn, dev);
>          ^
> smmu.c:2607:12: note: declared here
>  static int arm_smmu_assign_dev(struct domain *d, u8 devfn,
>             ^
> /local/scratch/ianj/xen.git/xen/Rules.mk:168: recipe for target 'smmu.o' 
> failed
> make[6]: *** [smmu.o] Error 1
> 
> I had a quick look but it's not a simple matter of plumbing through an
> additional flags parameter becuase the reassign_device method
> apparently doesn't take flags.

Considering that the parameter is ignored anyway, I'd suggest
following what was done for various of the rmrr_identity_mapping()
callers - just pass zero.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel