Re: [Xen-devel] [PATCH for-4.6 03/13] xl/libxl: remove a bunch of pointless assignments

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2015-07-23 at 08:59 +0100, Wei Liu wrote:
> Those values are  overwritten before they can be of any use.

I commented on a similar patch recently (having acked it):
    The flip side is that if the code uses the "init everything and
    goto out on error" idiom then the init might need to be put back if
    the code changes, hopefully even a regular compiler would spot this
    though.

The rc = ERROR_FAIL one is consistent with coding style.

coding style does say that things which might need cleaning up should
be initialised as they are declared, however I don't think any of the
pid/ret's here need cleanup. So:

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel