Re: [Xen-devel] [PATCH for-4.6 12/13] tools/ocaml: call libxl_dominfo_{init, dispose} in stub

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 23/07/15 09:38, Wei Liu wrote:
> On Thu, Jul 23, 2015 at 09:32:44AM +0100, Andrew Cooper wrote:
>> On 23/07/2015 08:59, Wei Liu wrote:
>>> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
>>> ---
>>> Cc: David Scott <dave.scott@xxxxxxxxxxxxx>
>>>
>>> As far as I can tell, all Val_$foo function does deep-copy, so we can
>>> safely call dispose in said function.
>> Sadly this is insufficient.  failwith_xl() longjump()s back into the
>> ocaml runtime, which ends up leaking any allocations made for dominfo.
>>
>> This is a systemic problem with the Ocaml bindings and I have a proposed
>> solution but it involves rewriting quite a lot of this code and is
>> definitely not 4.6 material.
>>
> Fine then. Systematic problem requires systematic fix.  Let's ignore the
> last two patches in this series.

Agreed.

What I not yet figured out how to fix is libxl__alloc_failed().

_exit() is not a reasonable out-of-memory action in a library,
especially not in use in a runtime which actually has a garbage collector.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel