Re: [Xen-devel] [v8][PATCH 13/16] libxl: construct e820 map with RDM information for HVM guest [and 1 more messages]

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Tiejun Chen writes ("[v8][PATCH 13/16] libxl: construct e820 map with RDM 
information for HVM guest"):
> Here we'll construct a basic guest e820 table via
> XENMEM_set_memory_map. This table includes lowmem, highmem
> and RDMs if they exist, and hvmloader would need this info
> later.
> 
> Note this guest e820 table would be same as before if the
> platform has no any RDM or we disable RDM (by default).
> 
> CC: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> CC: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> CC: Ian Campbell <ian.campbell@xxxxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> Signed-off-by: Tiejun Chen <tiejun.chen@xxxxxxxxx>
> ---
> v8:
> 
> * make that core construction function as arch-specific to make sure
>   we don't break ARM at this point.

But:

Tiejun Chen writes ("[v9][PATCH 13/16] libxl: construct e820 map with RDM 
information for HVM guest"):
...
> ---
> v8 ~ v9:
> 
> * Nothing is changed.


In fact the message for v8 is correct.  The message for v9 and later
is wrong.

Posting patches with "Nothing is changed", where substantial changes
have been made, is poor.


Also, you should have removed Wei's ack.  I will do that.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel