Re: [Xen-devel] [PATCH v12] introduce XENMEM_reserved_device_memory_map

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-07-22 at 04:42 -0600, Jan Beulich wrote:
> This is a prerequisite for punching holes into HVM and PVH guests' 
> P2M
> to allow passing through devices that are associated with (on VT-d)
> RMRRs.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Signed-off-by: Tiejun Chen <tiejun.chen@xxxxxxxxx>
> Acked-by: Kevin Tian <kevin.tian@xxxxxxxxx>

You explained on IRC that you had misinterpreted Daniel's response
about XSM and in fact such a check is not needed.

So I think the only pending changes are to move the union to the end of
xen_reserved_device_memory_map and to move the entire interface
definition under a #if defined(__XEN__) || defined(__XEN_TOOLS__).

All of the actual code here looks good to me and with those two changes
I would:
    Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel