Re: [Xen-devel] [PATCH RFC] libxl: fix build with glibc < 2.9

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Jul 21, 2015 at 03:06:29PM +0100, Ian Campbell wrote:
> On Mon, 2015-07-20 at 15:30 +0100, Jan Beulich wrote:
> > htobe*() and be*toh() don't exist there. While replacing the 32-bit
> > ones with hton() and ntoh() would be possible, there wouldn't be an
> > obvious replacement for the 64-bit ones. Hence just take what current
> > glibc (2.21) has (assuming __bswap_*() exists, which it does back to
> > at least 2.4 according to my checking).
> > 
> > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> > ---
> > Not sure whether I picked an appropriate header to place this in, or
> > an appropriate #ifdef to hook this onto. Hence the RFC.
> 
> I think they will do.
> 
> I was a bit confused by xl.c including libxl_osdeps.h, but I think that
> is an aberration and we don't install the header so it is not really
> "public".
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

I was about to object putting them in libxl_osdep.h because they are not
really OS-dependent. However we've dumped something similar there before
so I withdraw my objection.

FWIW

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel