Re: [Xen-devel] [PATCH for-4.6 2/3] xen: replace non-POSIX error codes

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Tue, Jul 21, 2015 at 5:15 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>> On 21.07.15 at 17:56, <roger.pau@xxxxxxxxxx> wrote:
>> Some DOMCTLs returned non-POSIX error codes, replace them with POSIX
>> compilant values instead. EBADRQC and EBADSLT are replaced by EINVAL, while
>> EUSERS is replaced with EOVERFLOW.
>
> Same here basically - I'd appreciate if we could use EINVAL only as
> a last resort error value, to make errors distinguishable.

What would be more helpful is if you suggested an alternate error code
for the two EINVAL changes in this patch.

In the case of the first one, it looks like this is an "internal"
hypercall used only to do continuation of paging domctls.  Guests
should never call this directly; -EINVAL seems perfectly suitable
here.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel