Re: [Xen-devel] [PATCH v6 07/15] VMX: add VMFUNC leaf 0 (EPTP switching) to emulator.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 21.07.15 at 01:58, <edmund.h.white@xxxxxxxxx> wrote:
> @@ -1838,6 +1839,19 @@ static void vmx_vcpu_update_vmfunc_ve(struct vcpu *v)
>      vmx_vmcs_exit(v);
>  }
>  
> +static int vmx_vcpu_emulate_vmfunc(struct cpu_user_regs *regs)
> +{
> +    int rc = X86EMUL_EXCEPTION;
> +    struct vcpu *curr = current;
> +
> +    if ( !cpu_has_vmx_vmfunc && altp2m_active(curr->domain) &&
> +         regs->_eax == 0 &&
> +         p2m_switch_vcpu_altp2m_by_id(curr, (uint16_t)regs->_ecx) )

Didn't you say in the other mail that you addressed all review
comments? Switching from ->ecx to ->_ecx here makes no
difference at all as long as you don't also drop the wrong cast.

With the cast dropped
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel