Re: [Xen-devel] [PATCH for-4.6 1/3] xen/x86/libxl: replace non-POSIX error codes used by PSR code

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Jan Beulich writes ("Re: [PATCH for-4.6 1/3] xen/x86/libxl: replace non-POSIX 
error codes used by PSR code"):
> On 21.07.15 at 17:56, <roger.pau@xxxxxxxxxx> wrote:
> > PSR was using EBADSLT and EUSERS which are not POSIX error codes, replace
> > them with EINVAL and EOVERFLOW respectively.
> 
> Considering that we use EINVAL for almost everything (well beyond
> parameter checking I'm afraid), I don't think using this value for
> something intended to yield a specific user mode error message is
> really a good choice. Looking at the two respective hypervisor side
> changes - how about e.g. using EDOM, EBADF, or ENXIO instead?

EBADF is rather poor because it's the same error code you would get if
your privcmd fd had been closed.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel