Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Chen, Tiejun writes ("Re: [v10][PATCH 11/16] tools/libxl: detect and avoid 
conflicts with RDM"):
> On 2015/7/21 19:11, Ian Jackson wrote:
> > The most obvious case is something like the following code
> >
> >    libxl_domain_config cfg;
> >    cfg.stuff = blah;
> >    cfg.rdm.strategy = HOST;
> >
> >    libxl_domain_create_new(&cfg, &domid);
> >    libxl_domain_destroy(domid);
> 
> I'm not sure about this procedure, so do you mean this doesn't free 
> d_config->num_rdms/d_config->rdms?

The domain destroy would not change cfg at all.

> If not, I should double check this duplication so what about a return in 
> the case of duplicating one entry?

What I am looking for is a *decision* about what the right behaviour
is, backed up by a *rationale*.

The most obvious answer to me would be that if an rdms array is
specified, the strategy should be ignored.  That is how the automatic
numa placement API works.

But another answer would be to take the union of the specified
regions.  That would be more complicated, because the union would have
to be computed.

>              if (d_config->rdms[i].start == rdm_start)
>                  return;

That doesn't, of course, compute the union.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel