Re: [Xen-devel] [PATCH v2 02/23] x86/boot: copy only text section from *.lnk file to *.bin file

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.07.15 at 16:28, <daniel.kiper@xxxxxxxxxx> wrote:

Without any explanation (description) I'm inclined to say this makes
things more fragile instead of improving the situation. As it looks
like we indeed pointlessly copy .eh_frame, but I think this would
better be avoided by suppressing its generation (i.e. add
-fno-asynchronous-unwind-tables just like Rules.mk has).

Jan

> Signed-off-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
> ---
>  xen/arch/x86/boot/build32.mk |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/x86/boot/build32.mk b/xen/arch/x86/boot/build32.mk
> index c208249..c83effe 100644
> --- a/xen/arch/x86/boot/build32.mk
> +++ b/xen/arch/x86/boot/build32.mk
> @@ -13,7 +13,7 @@ CFLAGS := $(filter-out -flto,$(CFLAGS))
>       sed 's/ /,0x/g' | sed 's/,0x$$//' | sed 's/^[0-9]*,/ .long /') >$@
>  
>  %.bin: %.lnk
> -     $(OBJCOPY) -O binary $< $@
> +     $(OBJCOPY) -O binary -j .text $< $@
>  
>  %.lnk: %.o
>       $(LD) $(LDFLAGS_DIRECT) -N -Ttext 0 -o $@ $<
> -- 
> 1.7.10.4




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel