Re: [Xen-devel] [PATCH 1/3] libxl: fix ref counting of libxlMigrationDstArgs

[Olaf Hering <olaf@xxxxxxxxx>]

On Thu, Jul 16, Jim Fehlig wrote:

> @@ -448,6 +438,8 @@ libxlDomainMigrationPrepare(virConnectPtr dconn,
>          virObjectUnref(socks[i]);
>      }
>      VIR_FREE(socks);
> +    virObjectUnref(args);

This is now below the 'error' label, so args has to be initialized.

[  149s] libxl/libxl_migration.c: In function 'libxlDomainMigrationPrepare':
[  149s] libxl/libxl_migration.c:463:19: warning: 'args' may be used 
uninitialized in this function [-Wmaybe-uninitialized]
[  149s]      virObjectUnref(args);
[  149s]                    ^

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel