Re: [Xen-devel] [v10][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Chen, Tiejun writes ("Re: [v10][PATCH 11/16] tools/libxl: detect and
avoid conflicts with RDM"):
> [Ian Jackson:]
> > The domain configuration specified to libxl might contain some rdms.
> > Then num_rdms in the incoming config would be nonzero.
> 
> We never set d_config->num_rdms/d_config->rdms before we goes inside 
> libxl__domain_device_construct_rdm(). And actually 
> libxl__domain_device_construct_rdm is only one place to set 
> d_config->num_rdms/d_config->rdms.

But d_config is a libxl_domain_config which is supplied by libxl's
caller.  It might contain some rdms.

> I guess this line make you or other guys confused so lets delete this 
> line directly.

I don't think I am very confused.

> And if you still worry about something, I can add assert() at the 
> beginning of this function like this,
> 
> assert(!d_config->num_rdms && !d_config->rdms).

If you are sure that this assertion is correct, then that would be
proper.

But as I say above, I don't think it is.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel