[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [v9][PATCH 07/16] hvmloader/e820: construct guest e820 table





On 2015/7/18 0:06, Jan Beulich wrote:
On 17.07.15 at 17:54, <tiejun.chen@xxxxxxxxx> wrote:
+    for ( i = nr-1; i > memory_map.nr_map; i-- )

Before you add memory_map.nr_map, you should be able to iterate
from 0 to (not inclusive) nr. At least as far as I recall the original
patch.


Sorry, I really don't understand what you want.

Before we add memory_map.nr_map, e820[0, nr) don't include low/high
memory, right?

Why? memory_map is representing the reserved areas only, isn't it?

+     * The memory map created by toolstack may include,
+     *
+     * #1. Low memory region
+     *
+     * Low RAM starts at least from 1M to make sure all standard regions
+     * of the PC memory map, like BIOS, VGA memory-mapped I/O and vgabios,
+     * have enough space.
+     *
+     * #2. Reserved regions if they exist
+     *
+     * #3. High memory region if it exists

Am I wrong with your expectation?

Thanks
Tiejun

If that's not the case, then of course everything is fine.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.