Re: [Xen-devel] [PATCH v9 06/11] xen: Introduce XEN_DOMCTL_soft_reset

[Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>]

Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> writes:

>>  
>> @@ -1010,6 +1017,29 @@ int domain_unpause_by_systemcontroller(struct domain 
>> *d)
>>      return 0;
>>  }
>>  
>> +int domain_soft_reset(struct domain *d)
>> +{
>> +    struct vcpu *v;
>> +    int rc;
>> +
>> +    spin_lock(&d->shutdown_lock);
>> +    for_each_vcpu ( d, v )
>> +        if ( !v->paused_for_shutdown )
>> +            return -EINVAL;
>
> Ahem. You leave the spinlock still locked :-(
>

Ouch... :-(

-- 
  Vitaly

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel