Re: [Xen-devel] [PATCH 4/6] libxc: expose xsaves/xgetbv1/xsavec to hvm guest

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.07.15 at 10:10, <shuai.ruan@xxxxxxxxx> wrote:
> Ok, Thanks Jan.
> I will add the descriptions in next version.
> 
> Below is the short descriptions.
> For CPUID with eax=0xd and ecx=0x1, ebx\ecx\edx may not be zero when xsaves 
> supported. Also with ecx>2, ecx\edx may not be zero. If we want expose xsaves 
> to HVM guest , we should not set them to zero. 
> 
> So in your opinions ,is it proper to add these code here?

Sure, provided you don't leak any bits that may become defined in
the future, and the non-zero setting of which might be inconsistent
with other CPUID data. I.e. without looking at the manual, I'd guess
the above is still a little too vague.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel