Re: [Xen-devel] [PATCH v2 19/20] xen/privcmd: Add support for Linux 64KB page granularity

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Thu, 16 Jul 2015, Stefano Stabellini wrote:
> > +   /* setup_hparams guarantees ret == 0 */
> > +   BUG_ON(xen_apply_to_page(page, setup_hparams, info));
> > +
> > +   set_xen_guest_handle(xatp.idxs, info->h_idxs);
> > +   set_xen_guest_handle(xatp.gpfns, info->h_gpfns);
> > +   set_xen_guest_handle(xatp.errs, info->h_errs);
> > +   xatp.size = info->h_iter;
> > +
> > +   rc = HYPERVISOR_memory_op(XENMEM_add_to_physmap_range, &xatp);
> 
> I would have thought that XENMEM_add_to_physmap_range operates at 4K
> granularity, regardless of how the guest decides to layout its
> pagetables. If so, the call to XENMEM_add_to_physmap_range needs to be
> moved within the function passed to xen_apply_to_page.

Sorry, this comment is wrong, please ignore it. The others are OK.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel