Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 11/25] tools/libxc: support to resume uncooperative HVM guests

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Yang Hongyang writes ("Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 11/25] 
tools/libxc: support to resume uncooperative HVM guests"):
> On 07/16/2015 11:40 PM, Ian Jackson wrote:
> >    what this patch is doing
> >
> >      That is, what the change in behaviour is.  This includes clearly
> >      distinguishing old behaviour, before the patch, from new
> >      behaviour, after the patch.  I appreciate that there may be
> >      language problems which are making this more difficult - I think
> >      your native language may not use tenses the way English does.  So
> >      we can help you with the language, but we need the old and new
> >      behaviours to be clearly marked in your message.
> 
> I thought this is being addressed in the commit message, sorry again
> for my poor English and not make it clear, I would appreciate your
> help.

Right.  Thanks.  I hope we can work on this together.  I appreciate
that working in a non-native language is difficult.

OK, at the moment I find the existing proposed commit message unclear
about before-and-after.  I'm not sure I can write it correctly.  Can I
make a suggestion ?  How about you send me a copy of it with
the different parts explicitly marked BEFORE: and AFTER: ?

> >    what the constraints on the new functionality will be.
> >
> >      It appears that you are supporting slow path resume for all HVM
> >      guests.  Is that true ?  Are there any cases left unhandled ?
> 
> For the first question, yes. For second, Sorry that I don't catch
> your question, did you mean in some cases resuming HVM through slow
> path will be unhandled?

What I mean is: I think that this patch has this overall effect:

   BEFORE: HVM resume for slow path does not work

   AFTER: HVM resume for slow path does work

But I have questions.  I don't know in what way it "does not work".
What happens instead ?

And, another question: is it true that

   AFTER: HVM resume for slow path does work in all cases

or

   AFTER: HVM resume for slow path works in some cases (specify!)
          but in other cases it (does something else - what?)

Does that make sense of my question ?


Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel