Re: [Xen-devel] [PATCH] xen: arm: bootfdt: Avoid reading off the front of *_cells array

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2015-07-16 at 14:06 +0200, Julien Grall wrote:
> Hi Ian,
> 
> On 16/07/2015 10:50, Ian Campbell wrote:
> > In device_tree_for_each_node the call to the callback was using
> > {address,size}_cells[depth - 1], which at depth 0 could read off the
> > front of the array.
> >
> > We already handled this correctly in the rest of the loop so fixup
> > this instance as well.
> >
> > Reported-by: Chris (Christopher) Brand <chris.brand@xxxxxxxxxxxx>
> > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > Cc: Chris (Christopher) Brand <chris.brand@xxxxxxxxxxxx>
> 
> Good catch! Do you plan to backport to Xen 4.5 and apply to Xen 4.6?

Yes on both counts. This is a bugfix as far as 4.6 is concerned.

> Reviewed-by: Julien Grall <julien.grall@xxxxxxxxxx>
> 
> Regards,
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel