Re: [Xen-devel] [v7][PATCH 07/16] hvmloader/e820: construct guest e820 table

[George Dunlap <dunlapg@xxxxxxxxx>]

On Thu, Jul 16, 2015 at 2:58 AM, Chen, Tiejun <tiejun.chen@xxxxxxxxx> wrote:
>> I think I would say:
>>
>> --
>> Now use the hypervisor-supplied memory map to build our final e820 table:
>> * Add regions for BIOS ranges and other special mappings not in the
>> hypervisor map
>> * Add in the hypervisor regions
>> * Adjust the lowmem and highmem regions if we've had to relocate
>> memory (adding a highmem region if necessary)
>> * Sort all the ranges so that they appear in memory order.
>> --
>
>
> I'll update this and thanks a lot.
>
>>
>>>
>>> CC: Keir Fraser <keir@xxxxxxx>
>>> CC: Jan Beulich <jbeulich@xxxxxxxx>
>>> CC: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>>> CC: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
>>> CC: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
>>> CC: Ian Campbell <ian.campbell@xxxxxxxxxx>
>>> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
>>> Signed-off-by: Tiejun Chen <tiejun.chen@xxxxxxxxx>
>>> ---
>
>
> [snip]
>
>>> +    /* Low RAM goes here. Reserve space for special pages. */
>>> +    BUG_ON(low_mem_end < (2u << 20));
>>
>>
>> Won't this BUG if the guest was actually given less than 2GiB of RAM?
>
>
> 2u << 20 = 0x200000, so this is 2M, not 2G :)

Oh, right. :-)

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel