Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 24/25] tools/libxl: move remus state into a seperate structure

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Yang Hongyang writes ("[Xen-devel] [PATCH v4 --for 4.6 COLOPre 24/25] 
tools/libxl: move remus state into a seperate structure"):
> Add a new structure remus state, and move concrete layer's private
> member to remus state.
> it is pure refactoring and no functional changes.

Thanks.  I don't have much to add to what Ian Campbell has said, but

>      if (dss->checkpointed_stream == LIBXL_CHECKPOINTED_STREAM_REMUS) {
> -        dss->interval = r_info->interval;
>          if (libxl_defbool_val(r_info->compression))
>              dss->xcflags |= XCFLAGS_CHECKPOINT_COMPRESS;

In your next version it would be worth mentioning the movement of this
initialisation in the commit message.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel