Re: [Xen-devel] [PATCH] libxl: events: Do not abort remus with ERROR_TIMEOUT

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Jul 15, 2015 at 02:35:56PM +0100, Ian Jackson wrote:
> When the timeout set for prompting the next remus iteration fires, we
> should not treat the ERROR_TIMEDOUT as an error.
> 
> Bug in 31c836f4 "libxl: events: Permit timeouts to signal ao abort".
> 
> Reported-by: Yang Hongyang <yanghy@xxxxxxxxxxxxxx>
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> CC: Yang Hongyang <yanghy@xxxxxxxxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> CC: Ian Campbell <ian.campbell@xxxxxxxxxx>

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

> ---
>  tools/libxl/libxl_dom.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
> index 81adb3d..4cb247a 100644
> --- a/tools/libxl/libxl_dom.c
> +++ b/tools/libxl/libxl_dom.c
> @@ -2024,6 +2024,9 @@ static void remus_next_checkpoint(libxl__egc *egc, 
> libxl__ev_time *ev,
>  
>      STATE_AO_GC(dss->ao);
>  
> +    if (rc == ERROR_TIMEDOUT) /* As intended */
> +        rc = 0;
> +
>      /*
>       * Time to checkpoint the guest again. We return 1 to libxc
>       * (xc_domain_save.c). in order to continue executing the infinite loop
> -- 
> 1.7.10.4

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel