Re: [Xen-devel] [PATCH for-4.6] tools/hotplug: Add an initscript to start "xl devd" in a driver domain

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-07-15 at 14:26 +0100, Wei Liu wrote:
> On Wed, Jul 15, 2015 at 12:07:30PM +0100, Ian Campbell wrote:
> > The removal of the udev rules highlighted that although it has been
> > replaced by "xl devd" there isn't an initscript to replace it.
> > 
> > To enable this add a --pidfile option to xl devd.
> > 
> > Tested on Linux by running the script in dom0 and checking the daemon
> > was started/stopped, but not in an actual driver domain environment
> > since I don't have one conveniently available. I also checked that
> > running without the --pidfile option still works.
> > 
> > Scripts mainly cribbed from the xencommons for each platform.
> > 
> > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > Cc: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
> > Cc: Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx>
> > Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> > ---
> > For 4.6: I think having removed the udev rules we ought to include
> > this, it's basically zero risk to normal operation.
> > 
> > Nothing seems to start xl devd for domain 0 in *BSD, nor is xenbackend
> > started. Is that correct?
> > ---
> >  .gitignore                                    |  3 ++
> >  tools/configure                               |  5 +-
> >  tools/configure.ac                            |  3 ++
> >  tools/hotplug/FreeBSD/Makefile                |  2 +-
> >  tools/hotplug/FreeBSD/rc.d/xendriverdomain.in | 48 +++++++++++++++++
> >  tools/hotplug/Linux/Makefile                  |  3 ++
> >  tools/hotplug/Linux/init.d/xendriverdomain.in | 77 
> > +++++++++++++++++++++++++++
> >  tools/hotplug/NetBSD/Makefile                 |  2 +-
> >  tools/hotplug/NetBSD/rc.d/xendriverdomain.in  | 49 +++++++++++++++++
> >  tools/libxl/xl_cmdimpl.c                      | 42 +++++++++++++--
> >  tools/libxl/xl_cmdtable.c                     |  3 +-
> 
> Systemd unit file is missing.

Yes, it is.

I don't think it matters, systemd is supposed to have support for
"legacy" init scripts and this one is simple enough IMHO to not need any
of the special sauce that a unit would give.

If some systemd person wants to add a unit file then they can do so.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel