Re: [Xen-devel] [PATCH v4 08/17] xen/arm: ITS: Add APIs to add and assign device

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 10/07/2015 16:52, Ian Campbell wrote:
> > +static struct its_device *its_alloc_device(u32 devid)
> > +{
> > +    struct its_device *dev;
> > +    paddr_t *itt;
> > +    unsigned long *lpi_map;
> > +    int lpi_base, nr_lpis, sz;
> > +    u32 nr_ites;
> > +
> > +    dev = xzalloc(struct its_device);
> > +    if ( dev == NULL )
> > +        return NULL;
> > +
> > +    dev->its = its_get_phys_node(devid);
> > +    /* TODO: Use pci helper to get nvecs */
> > +    nr_ites = 64;
> Please add nr_ites as a parameter to this function and to
> its_add_device, such that this hardcoding can be pushed all the way down
> into the final patch which adds the temporary registration code in
> xen/arch/arm/platforms/thunderx.c.
+1, I would also add the physical ITS in parameter as it's not possible 
to get it based on the devID (see its_get_phys_node).
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel