Re: [Xen-devel] [PATCH for-4.6] tools: libxl: check errors from libxl_create_logfile for stubdom log

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Jul 15, 2015 at 01:14:41PM +0100, Ian Campbell wrote:
> Spotted by Coverity after the recent similar fix to
> libxl__create_qemu_logfile.
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

> ---
>  tools/libxl/libxl_dm.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> index f9911ac..36deb2c 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -1257,7 +1257,8 @@ static void spawn_stub_launch_dm(libxl__egc *egc,
>              case STUBDOM_CONSOLE_LOGGING:
>                  name = libxl__sprintf(gc, "qemu-dm-%s",
>                                        libxl_domid_to_name(ctx, guest_domid));
> -                libxl_create_logfile(ctx, name, &filename);
> +                ret = libxl_create_logfile(ctx, name, &filename);
> +                if (ret) goto out;
>                  console[i].output = libxl__sprintf(gc, "file:%s", filename);
>                  free(filename);
>                  break;
> -- 
> 2.1.4

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel