Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 06/25] libxl/remus: introduce libxl__remus_teardown

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-07-15 at 15:45 +0800, Yang Hongyang wrote:
> introduce libxl__remus_teardown to teardown Remus devices.
> 
> Signed-off-by: Yang Hongyang <yanghy@xxxxxxxxxxxxxx>

Acked-by: Ian Campbell <Ian.Campbell@xxxxxxxxxx>

If you need to respin then you might consider inverting the if remus
check in domain_suspend_done and calling this new function if true, e.g.

    if (dss->remus) {
        libxl__remus_teardown(...)
        return;
    }

    dss->callback(egc, dss, rc);

I think the control flow would feel more natural then.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel